]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
scsi: sd: fix missing put_disk() when device_add(&disk_dev) fails
authorYang Xiuwei <yangxiuwei@kylinos.cn>
Mon, 30 Mar 2026 01:49:52 +0000 (09:49 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 9 Apr 2026 02:10:44 +0000 (22:10 -0400)
commit1e111c4b3a726df1254670a5cc4868cedb946d37
tree20d3ac97d241e800b96621939002e54495b7cde2
parent1a2f61970a6365ca5fb1a667300348815ae81727
scsi: sd: fix missing put_disk() when device_add(&disk_dev) fails

If device_add(&sdkp->disk_dev) fails, put_device() runs
scsi_disk_release(), which frees the scsi_disk but leaves the gendisk
referenced. The device_add_disk() error path in sd_probe() calls
put_disk(gd); call put_disk(gd) here to mirror that cleanup.

Fixes: 265dfe8ebbab ("scsi: sd: Free scsi_disk device via put_device()")
Cc: stable@vger.kernel.org
Reviewed-by: John Garry <john.g.garry@oracle.com>
Signed-off-by: Yang Xiuwei <yangxiuwei@kylinos.cn>
Link: https://patch.msgid.link/20260330014952.152776-1-yangxiuwei@kylinos.cn
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c