]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix logical replication TAP test to read publisher log correctly.
authorFujii Masao <fujii@postgresql.org>
Wed, 4 Feb 2026 15:46:09 +0000 (00:46 +0900)
committerFujii Masao <fujii@postgresql.org>
Wed, 4 Feb 2026 15:47:04 +0000 (00:47 +0900)
commit221232596fc6a26daffa64c294604f4f8507b95c
tree6b99f2e5ede0149314fe61dcd345badc5a16d36e
parent73ac2b37401d7aa910ebd81795bb0f4faf0eaab3
Fix logical replication TAP test to read publisher log correctly.

Commit 5f13999aa11 added a TAP test for GUC settings passed via the
CONNECTION string in logical replication, but the buildfarm member
sungazer reported test failures.

The test incorrectly used the subscriber's log file position as the
starting offset when reading the publisher's log. As a result, the test
failed to find the expected log message in the publisher's log and
erroneously reported a failure.

This commit fixes the test to use the publisher's own log file position
when reading the publisher's log.

Also, to avoid similar confusion in the future, this commit splits the single
$log_location variable into $log_location_pub and $log_location_sub,
clearly distinguishing publisher and subscriber log positions.

Backpatched to v15, where commit 5f13999aa11 introduced the test.

Per buildfarm member sungazer.
This issue was reported and diagnosed by Alexander Lakhin.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/966ec3d8-1b6f-4f57-ae59-fc7d55bc9a5a@gmail.com
Backpatch-through: 15
src/test/subscription/t/001_rep_changes.pl