]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/ingenic: crtc: Switch to ingenic_drm_get_new_priv_state()
authorMaxime Ripard <mripard@kernel.org>
Tue, 30 Sep 2025 10:59:52 +0000 (12:59 +0200)
committerMaxime Ripard <mripard@kernel.org>
Mon, 6 Oct 2025 11:59:22 +0000 (13:59 +0200)
commit22c0dd19113a15b5d1a294559f8b3cf16cb6cec7
treed4a659fe6c1e3469ebf8bcbd51e36025fa5f9676
parent4ae41729a658aee3e68a609cc0275658b724ebc4
drm/ingenic: crtc: Switch to ingenic_drm_get_new_priv_state()

The ingenic CRTC atomic_enable() implementation will indirectly call
drm_atomic_get_private_obj_state() through ingenic_drm_get_priv_state().

drm_atomic_get_private_obj_state() will either return the new state for
the object in the global state if it exists, or will allocate a new one
and add it to the global state.

atomic_enable() however isn't allowed to modify the global state. So
what the implementation should use is the
drm_atomic_get_new_private_obj_state() helper to get the new state for
the CRTC, without performing an extra allocation.

We still need to make sure the private state will be part of the global
state by the time atomic_enable runs, so we still need to call
ingenic_drm_get_priv_state() in atomic_check. We can then call
ingenic_drm_get_new_priv_state() in atomic_enable, which is a wrapper
around drm_atomic_get_new_private_obj_state().

Reported-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://lore.kernel.org/r/20250930-drm-no-more-existing-state-v5-37-eeb9e1287907@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/ingenic/ingenic-drm-drv.c