]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: macb: replace macb_writel() call by queue_writel() to update queue ISR
authorCyrille Pitchen <cyrille.pitchen@atmel.com>
Thu, 24 Mar 2016 14:40:04 +0000 (15:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 May 2020 08:26:32 +0000 (10:26 +0200)
commit236de7848762ec6b2296f4ea341581c2fa2ab1bd
treec913a75f192c0bec74ff66c9663cc87d993684f2
parent4cbe341dce1686602bbf83f525cf360af61756ab
net: macb: replace macb_writel() call by queue_writel() to update queue ISR

commit ba5049945421b8d2f3e2af786a15d13b82316503 upstream.

macb_interrupt() should not use macb_writel(bp, ISR, <value>) but only
queue_writel(queue, ISR, <value>).

There is one IRQ and one set of {ISR, IER, IDR, IMR} [1] registers per
queue on gem hardware, though only queue0 is actually used for now to
receive frames: other queues can already be used to transmit frames.

The queue_readl() and queue_writel() helper macros are designed to access
the relevant IRQ registers.

[1]
ISR: Interrupt Status Register
IER: Interrupt Enable Register
IDR: Interrupt Disable Register
IMR: Interrupt Mask Register

Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Fixes: bfbb92c44670 ("net: macb: Handle the RXUBR interrupt on all devices")
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/cadence/macb.c