]> git.ipfire.org Git - thirdparty/bind9.git/commit
simplify code by removing return values where possible
authorEvan Hunt <each@isc.org>
Fri, 19 Apr 2024 22:57:32 +0000 (15:57 -0700)
committerEvan Hunt <each@isc.org>
Thu, 25 Apr 2024 17:29:07 +0000 (10:29 -0700)
commit237123e500a8b74c075aeccf37e391d08c2df362
tree110f626e622dd32cf255b973ed99dda93129528d
parentb1b1ca8ca405cc53e255e0fce008f8fa3a7a3656
simplify code by removing return values where possible

fix_iterator() and related functions are quite difficult to read.
perhaps it would be a little clearer if we didn't assign values
to variables that won't subsequently be used, or unnecessarily
pop the stack and then push the same value back onto it.

also, in dns_qp_lookup() we previously called fix_iterator(),
removed the leaf from the top of the iterator stack, and then
added it back on. this would be clearer if we just push the leaf
onto the stack when we need to, but leave the stack alone when
it's already complete.
lib/dns/qp.c