]> git.ipfire.org Git - thirdparty/linux.git/commit
regulator: mt6363: Fix incorrect and redundant IRQ disposal in probe
authorFelix Gu <ustc.gu@gmail.com>
Sun, 22 Feb 2026 18:24:34 +0000 (02:24 +0800)
committerMark Brown <broonie@kernel.org>
Sun, 1 Mar 2026 23:48:17 +0000 (23:48 +0000)
commit23942b71f07cc99e39d9216a5b370df494759d8c
treea0e95b880372f4caf26d35c2deb1c0a4e0b37df4
parent11439c4635edd669ae435eec308f4ab8a0804808
regulator: mt6363: Fix incorrect and redundant IRQ disposal in probe

In mt6363_regulator_probe(), devm_add_action_or_reset() is used to
automatically dispose of the IRQ mapping if the probe fails or the
device is removed.

The manual call to irq_dispose_mapping() in the error path was redundant
as the reset action already triggers mt6363_irq_remove(). Furthermore,
the manual call incorrectly passed the hardware IRQ number (info->hwirq)
instead of the virtual IRQ mapping (info->virq).

Remove the redundant and incorrect manual disposal.

Fixes: 3c36965df808 ("regulator: Add support for MediaTek MT6363 SPMI PMIC Regulators")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260223-mt6363-v1-1-c99a2e8ac621@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/mt6363-regulator.c