]> git.ipfire.org Git - thirdparty/linux.git/commit
xen/privcmd: fix double free via VMA splitting
authorJuergen Gross <jgross@suse.com>
Fri, 10 Apr 2026 07:20:04 +0000 (09:20 +0200)
committerJuergen Gross <jgross@suse.com>
Thu, 23 Apr 2026 13:32:59 +0000 (15:32 +0200)
commit24daca4fc07f3ff8cd0e3f629cd982187f48436a
tree30dffceb6ca8433730f2168d4cf5dcb535ce0caf
parent27fdbab4221b375de54bf91919798d88520c6e28
xen/privcmd: fix double free via VMA splitting

privcmd_vm_ops defines .close (privcmd_close), but neither .may_split
nor .open. When userspace does a partial munmap() on a privcmd mapping,
the kernel splits the VMA via __split_vma(). Since may_split is NULL,
the split is allowed. vm_area_dup() copies vm_private_data (a pages
array allocated in alloc_empty_pages()) into the new VMA without any
fixup, because there is no .open callback.

Both VMAs now point to the same pages array. When the unmapped portion
is closed, privcmd_close() calls:
    - xen_unmap_domain_gfn_range()
    - xen_free_unpopulated_pages()
    - kvfree(pages)

The surviving VMA still holds the dangling pointer. When it is later
destroyed, the same sequence runs again, which leads to a double free.

Fix this issue by adding a .may_split callback denying the VMA split.

This is XSA-487 / CVE-2026-31787

Fixes: d71f513985c2 ("xen: privcmd: support autotranslated physmap guests.")
Reported-by: Atharva Vartak <atharva.a.vartak@gmail.com>
Suggested-by: Atharva Vartak <atharva.a.vartak@gmail.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
drivers/xen/privcmd.c