]> git.ipfire.org Git - thirdparty/bind9.git/commit
Various little fixes found by coccinelle
authorOndřej Surý <ondrej@sury.org>
Mon, 9 Sep 2019 12:05:31 +0000 (14:05 +0200)
committerOndřej Surý <ondrej@sury.org>
Tue, 1 Oct 2019 14:48:55 +0000 (16:48 +0200)
commit288f5a4b525da46fffe0f00f68cc9922aa2ab706
tree7af9382e1b4c62302d234b5dcac2106311f9e3b0
parentc2e8a111f57858a0c37c4e01947520198ca78f2e
Various little fixes found by coccinelle

The coccinellery repository provides many little semantic patches to fix common
problems in the code.  The number of semantic patches in the coccinellery
repository is high and most of the semantic patches apply only for Linux, so it
doesn't make sense to run them on regular basis as the processing takes a lot of
time.

The list of issue found in BIND 9, by no means complete, includes:

- double assignment to a variable
- `continue` at the end of the loop
- double checks for `NULL`
- useless checks for `NULL` (cannot be `NULL`, because of earlier return)
- using `0` instead of `NULL`
- useless extra condition (`if (foo) return; if (!foo) { ...; }`)
- removing & in front of static functions passed as arguments
24 files changed:
bin/delv/delv.c
bin/dig/dighost.c
bin/dnssec/dnssec-signzone.c
bin/named/fuzz.c
contrib/dlz/drivers/dlz_bdbhpt_driver.c
contrib/dlz/drivers/dlz_mysql_driver.c
contrib/dlz/drivers/dlz_odbc_driver.c
contrib/dlz/drivers/dlz_postgres_driver.c
contrib/dlz/modules/bdbhpt/dlz_bdbhpt_dynamic.c
contrib/dlz/modules/common/dlz_dbi.c
contrib/dlz/modules/filesystem/dlz_filesystem_dynamic.c
contrib/dlz/modules/mysql/dlz_mysql_dynamic.c
contrib/dlz/modules/sqlite3/dlz_sqlite3_dynamic.c
lib/dns/dnsrps.c
lib/dns/dnstap.c
lib/dns/ds.c
lib/dns/openssldh_link.c
lib/dns/opensslecdsa_link.c
lib/dns/openssleddsa_link.c
lib/dns/opensslrsa_link.c
lib/isc/xoshiro128starstar.c
lib/isccfg/namedconf.c
lib/ns/hooks.c
lib/ns/xfrout.c