]> git.ipfire.org Git - thirdparty/linux.git/commit
idpf: Fix flow rule delete failure due to invalid validation
authorSreedevi Joshi <sreedevi.joshi@intel.com>
Tue, 13 Jan 2026 18:01:13 +0000 (12:01 -0600)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 25 Feb 2026 19:43:57 +0000 (11:43 -0800)
commit2c31557336a8e4d209ed8d4513cef2c0f15e7ef4
tree4f308e2ec05503ebaeb06f509010fdbc616ff1f4
parent1500a8662d2d41d6bb03e034de45ddfe6d7d362d
idpf: Fix flow rule delete failure due to invalid validation

When deleting a flow rule using "ethtool -N <dev> delete <location>",
idpf_sideband_action_ena() incorrectly validates fsp->ring_cookie even
though ethtool doesn't populate this field for delete operations. The
uninitialized ring_cookie may randomly match RX_CLS_FLOW_DISC or
RX_CLS_FLOW_WAKE, causing validation to fail and preventing legitimate
rule deletions. Remove the unnecessary sideband action enable check and
ring_cookie validation during delete operations since action validation
is not required when removing existing rules.

Fixes: ada3e24b84a0 ("idpf: add flow steering support")
Signed-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/idpf/idpf_ethtool.c