]> git.ipfire.org Git - thirdparty/bind9.git/commit
Call isccc_ccmsg_invalidate() when shutting down the connection
authorOndřej Surý <ondrej@isc.org>
Fri, 27 Oct 2023 08:16:13 +0000 (10:16 +0200)
committerOndřej Surý <ondrej@isc.org>
Fri, 27 Oct 2023 08:53:26 +0000 (10:53 +0200)
commit2d2c249958d3f983e77bdecaf4bfc4553dacad62
treee0c92625f34f9dc85b835c1676ade5839f062b98
parent07f569e2f60de0078a22a181021342f19c1b1c41
Call isccc_ccmsg_invalidate() when shutting down the connection

Previously, the isccc_ccmsg_invalidate() was called from conn_free() and
this could lead to netmgr calling control_recvmessage() after we
detached the reading controlconnection_t reference, but it wouldn't be
the last reference because controlconnection_t is also attached/detached
when sending response or running command asynchronously.

Instead, move the isccc_ccmsg_invalidate() call to control_recvmessage()
error handling path to make sure that control_recvmessage() won't be
ever called again from the netmgr.
bin/named/controlconf.c