]> git.ipfire.org Git - thirdparty/linux.git/commit
platform/x86: uniwill-laptop: Rename FN lock and super key lock attrs
authorArmin Wolf <W_Armin@gmx.de>
Wed, 18 Feb 2026 00:50:58 +0000 (01:50 +0100)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 23 Feb 2026 16:06:38 +0000 (18:06 +0200)
commit2d53dfacf067968a9ff90c03700fb9b28049f4c6
tree6f4c06d30b07fd0fecefa407e13faf2f5f3cf386
parente3aa6feaf0cc30a3c941d15ff04bc1005a8aa315
platform/x86: uniwill-laptop: Rename FN lock and super key lock attrs

It turns out that both sysfs attributes actually directly control
the FN lock status/super key enable status, rather than the
triggering of the associated events. This behavior was first observed
on a Tuxedo notebook and was belived to be a hardware quirk.
However, it seems that i simply misunderstood the manual of the
OEM software for Intel NUC devices. The correct behavior is:

- fn_lock_toggle_enable enables/disables FN lock mode
- super_key_toggle_enable enables/disables the super key

Rename both sysfs attributes to avoid confusing users.

Fixes: d050479693bb ("platform/x86: Add Uniwill laptop driver")
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://patch.msgid.link/20260218005101.73680-2-W_Armin@gmx.de
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Documentation/ABI/testing/sysfs-driver-uniwill-laptop
Documentation/admin-guide/laptops/uniwill-laptop.rst
drivers/platform/x86/uniwill/uniwill-acpi.c
drivers/platform/x86/uniwill/uniwill-wmi.h