]> git.ipfire.org Git - thirdparty/elfutils.git/commit
libdwfl: remove broken coalescing logic in dwfl_report_segment
authorOmar Sandoval <osandov@fb.com>
Thu, 12 Dec 2019 01:29:44 +0000 (17:29 -0800)
committerMark Wielaard <mark@klomp.org>
Wed, 18 Dec 2019 20:18:59 +0000 (21:18 +0100)
commit2e75c987d591d3af313ee38a31ab677f6f4eb1ff
tree7f2bfca702f5dca0ce5e82a34d222273fa1cfb3f
parent277c2c54f5579523649a29d26966bfed35a159bf
libdwfl: remove broken coalescing logic in dwfl_report_segment

dwfl_report_segment has some logic that detects when a segment is
contiguous with the previously reported segment, in which case it's
supposed to coalesce them. However, in this case, it actually returns
without updating the segment array at all. As far as I can tell, this
has always been broken. It appears that no one uses the coalescing logic
anyways, as they pass IDENT as NULL. Let's just get rid of the logic and
add a test case.

Signed-off-by: Omar Sandoval <osandov@fb.com>
.gitignore
libdwfl/ChangeLog
libdwfl/libdwfl.h
libdwfl/libdwflP.h
libdwfl/segment.c
tests/ChangeLog
tests/Makefile.am
tests/dwfl-report-segment-contiguous.c [new file with mode: 0644]