]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ceph: don't skip updating wanted caps when cap is stale
authorYan, Zheng <zyan@redhat.com>
Tue, 10 Mar 2020 11:34:20 +0000 (19:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Apr 2020 14:31:11 +0000 (16:31 +0200)
commit2ebb10f20ac8811ebd5ff08744c863ea41828e83
tree1f4e6520322b7126fbb7b17edc00eefe99b44737
parenta7eba547137b9e699cea0d363ec2e31c5ef5f281
ceph: don't skip updating wanted caps when cap is stale

[ Upstream commit 0aa971b6fd3f92afef6afe24ef78d9bb14471519 ]

1. try_get_cap_refs() fails to get caps and finds that mds_wanted
   does not include what it wants. It returns -ESTALE.
2. ceph_get_caps() calls ceph_renew_caps(). ceph_renew_caps() finds
   that inode has cap, so it calls ceph_check_caps().
3. ceph_check_caps() finds that issued caps (without checking if it's
   stale) already includes caps wanted by open file, so it skips
   updating wanted caps.

Above events can cause an infinite loop inside ceph_get_caps().

Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/ceph/caps.c