]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
hwmon: (pmbus/isl68137) Add mutex protection for AVS enable sysfs attributes
authorSanman Pradhan <psanman@juniper.net>
Thu, 19 Mar 2026 17:31:29 +0000 (17:31 +0000)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 24 Mar 2026 14:55:34 +0000 (07:55 -0700)
commit3075a3951f7708da5a8ab47b0b7d068a32f69e58
tree0b2d38b6b4dcfcda820e107ea82b0489925e0f52
parentf7e775c4694782844c66da5316fed82881835cf8
hwmon: (pmbus/isl68137) Add mutex protection for AVS enable sysfs attributes

The custom avs0_enable and avs1_enable sysfs attributes access PMBus
registers through the exported API helpers (pmbus_read_byte_data,
pmbus_read_word_data, pmbus_write_word_data, pmbus_update_byte_data)
without holding the PMBus update_lock mutex. These exported helpers do
not acquire the mutex internally, unlike the core's internal callers
which hold the lock before invoking them.

The store callback is especially vulnerable: it performs a multi-step
read-modify-write sequence (read VOUT_COMMAND, write VOUT_COMMAND, then
update OPERATION) where concurrent access from another thread could
interleave and corrupt the register state.

Add pmbus_lock_interruptible()/pmbus_unlock() around both the show and
store callbacks to serialize PMBus register access with the rest of the
driver.

Fixes: 038a9c3d1e424 ("hwmon: (pmbus/isl68137) Add driver for Intersil ISL68137 PWM Controller")
Cc: stable@vger.kernel.org
Signed-off-by: Sanman Pradhan <psanman@juniper.net>
Link: https://lore.kernel.org/r/20260319173055.125271-3-sanman.pradhan@hpe.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/pmbus/isl68137.c