]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
i2c: tegra: make tegra_i2c_mutex_unlock() return void
authorSaurav Sachidanand <sauravsc@amazon.com>
Thu, 7 May 2026 22:11:45 +0000 (22:11 +0000)
committerAndi Shyti <andi.shyti@kernel.org>
Wed, 13 May 2026 22:14:20 +0000 (00:14 +0200)
commit30792d12842901f5276f466a960962d5bfa15cc8
tree6ee5e561ee98e8a77f91a01b4a31d13d13767223
parent57cf4e8d6a57dc2ef5810f4852a23ba4c71b74bb
i2c: tegra: make tegra_i2c_mutex_unlock() return void

tegra_i2c_mutex_unlock() returning an error that overwrites the transfer
result causes silent loss of I2C transfer errors. If the transfer failed
but the unlock succeeded, the error was lost and the function incorrectly
reported success.

Rather than propagating the unlock error (which is not actionable by the
caller - the I2C message may have been sent regardless), convert the
function to return void and WARN on the unexpected condition. If the
unlock fails, subsequent lock attempts will fail anyway, making the error
visible on the next transfer.

Fixes: 6077cfd716fb ("i2c: tegra: Add support for SW mutex register")
Signed-off-by: Saurav Sachidanand <sauravsc@amazon.com>
Cc: <stable@vger.kernel.org> # v7.0+
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20260507221145.62183-3-sauravsc@amazon.com
drivers/i2c/busses/i2c-tegra.c