]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: amd: acp-mach-common: Add missing error check for clock acquisition
authorChen Ni <nichen@iscas.ac.cn>
Tue, 10 Mar 2026 04:43:27 +0000 (12:43 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 11 Mar 2026 19:18:17 +0000 (19:18 +0000)
commit30c64fb9839949f085c8eb55b979cbd8a4c51f00
tree9307e413bf3d2bffac151efe73c45f74fb374f3f
parenta9683730e8b1d632674f81844ed03ddfbe4821c0
ASoC: amd: acp-mach-common: Add missing error check for clock acquisition

The acp_card_rt5682_init() and acp_card_rt5682s_init() functions did not
check the return values of clk_get(). This could lead to a kernel crash
when the invalid pointers are later dereferenced by clock core
functions.

Fix this by:
1. Changing clk_get() to the device-managed devm_clk_get().
2. Adding IS_ERR() checks immediately after each clock acquisition.

Fixes: 8b7256266848 ("ASoC: amd: acp: Add support for RT5682-VS codec")
Fixes: d4c750f2c7d4 ("ASoC: amd: acp: Add generic machine driver support for ACP cards")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Link: https://patch.msgid.link/20260310044327.2582018-1-nichen@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp/acp-mach-common.c