]> git.ipfire.org Git - thirdparty/linux.git/commit
Bluetooth: hci_ll: Fix firmware leak on error path
authorAnas Iqbal <mohd.abd.6602@gmail.com>
Sun, 15 Mar 2026 10:51:37 +0000 (10:51 +0000)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Thu, 19 Mar 2026 18:43:43 +0000 (14:43 -0400)
commit31148a7be723aa9f2e8fbd62424825ab8d577973
tree1c3db5707bd1f94b1869bd1c1bd3d3c0efeb3cdf
parentb6807cfc195ef99e1ac37b2e1e60df40295daa8c
Bluetooth: hci_ll: Fix firmware leak on error path

Smatch reports:

drivers/bluetooth/hci_ll.c:587 download_firmware() warn:
'fw' from request_firmware() not released on lines: 544.

In download_firmware(), if request_firmware() succeeds but the returned
firmware content is invalid (no data or zero size), the function returns
without releasing the firmware, resulting in a resource leak.

Fix this by calling release_firmware() before returning when
request_firmware() succeeded but the firmware content is invalid.

Fixes: 371805522f87 ("bluetooth: hci_uart: add LL protocol serdev driver support")
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: Anas Iqbal <mohd.abd.6602@gmail.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
drivers/bluetooth/hci_ll.c