]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
cxl/memdev: fix deadlock in cxl_memdev_autoremove() on attach failure
authorGregory Price <gourry@gourry.net>
Wed, 11 Feb 2026 19:22:27 +0000 (14:22 -0500)
committerDave Jiang <dave.jiang@intel.com>
Mon, 23 Feb 2026 16:03:44 +0000 (09:03 -0700)
commit318c58852e686c009825ae8c071080b9ccdd2af0
treeac34da4647343e08057b8a360bc1207e72c8bf8b
parent6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
cxl/memdev: fix deadlock in cxl_memdev_autoremove() on attach failure

cxl_memdev_autoremove() takes device_lock(&cxlmd->dev) via guard(device)
and then calls cxl_memdev_unregister() when the attach callback was
provided but cxl_mem_probe() failed to bind.

cxl_memdev_unregister() calls
  cdev_device_del()
    device_del()
      bus_remove_device()
        device_release_driver()

This path is reached when a driver uses the @attach parameter to
devm_cxl_add_memdev() and the CXL topology fails to enumerate (e.g.
DVSEC range registers decode outside platform-defined CXL ranges,
causing the endpoint port probe to fail).

Add cxl_memdev_attach_failed() to set the scope of the check correctly.

Reported-by: kreview-c94b85d6d2
Fixes: 29317f8dc6ed ("cxl/mem: Introduce cxl_memdev_attach for CXL-dependent operation")
Signed-off-by: Gregory Price <gourry@gourry.net>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Link: https://patch.msgid.link/20260211192228.2148713-1-gourry@gourry.net
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/memdev.c