]> git.ipfire.org Git - thirdparty/libvirt.git/commit
conf: Remove nonsensical requirement of nvram format matching firmware format
authorPeter Krempa <pkrempa@redhat.com>
Thu, 15 Aug 2024 15:02:54 +0000 (17:02 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 15 Nov 2024 08:42:04 +0000 (09:42 +0100)
commit32228ecb02fde91ce91aa960d187d545bfbc03cf
tree5c07f4d932a8fa347ea1a77d80fe8018f7133edd
parentd3016e47be5f813b85c7bc3f9bbe9a148d589fa9
conf: Remove nonsensical requirement of nvram format matching firmware format

The nvram image can have any supported format and there's no technical
requirement of them having the same format. In fact the actual nvram
image doesn't necessarily need to have the same format as the template
if the user is willing to format it themselves (as libvirt is not going
to convert it).

Remove the nonsensical check and adjust tests. The test case required
swapping around the format in order to work properly.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/conf/domain_conf.c
tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch.x86_64-latest.args [new file with mode: 0644]
tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch.x86_64-latest.err [deleted file]
tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch.x86_64-latest.xml [new file with mode: 0644]
tests/qemuxmlconfdata/firmware-auto-efi-format-mismatch.xml
tests/qemuxmlconftest.c