]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ethtool: rss: avoid device context leak on reply-build failure
authorJakub Kicinski <kuba@kernel.org>
Fri, 22 May 2026 23:06:47 +0000 (16:06 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 26 May 2026 15:17:57 +0000 (08:17 -0700)
commit32a9ecde62731c9f7412507709192c84dafc38d1
tree9d85d0a411f97072868f67c70b0bb24f3d7e33a3
parent78ccf1a70c6378e1f5073a8c2209b5129067b925
ethtool: rss: avoid device context leak on reply-build failure

We wait with filling the reply for new RSS context creation
until after the driver ->create_rxfh_context call. The driver
needs to fill some of the defaults in the context. The failure
of rss_fill_reply() is somewhat theoretical, but doesn't take
much effort to handle it properly. Call ->remove_rxfh_context().

If the driver's remove callback fails (some implementations like sfc
can return real command errors from firmware RPCs) - skip the xa_erase
and kfree, leaving the context in the xarray. This matches how
ethnl_rss_delete_doit() behaves.

Fixes: a166ab7816c5 ("ethtool: rss: support creating contexts via Netlink")
Link: https://patch.msgid.link/20260522230647.1705600-7-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/rss.c