]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mac80211: Allow HE operation to be longer than expected.
authorBrian Norris <briannorris@chromium.org>
Tue, 23 Feb 2021 05:19:26 +0000 (13:19 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Mar 2021 12:30:21 +0000 (14:30 +0200)
commit331d42f56df84b813d7e5b7644409d905549239d
tree653b9d8a32b02e7d5d8bd7d71b2ce85f7c33e0a0
parentfe744cff6616d334583b0687777300730a969ad4
mac80211: Allow HE operation to be longer than expected.

[ Upstream commit 0f7e90faddeef53a3568f449a0c3992d77510b66 ]

We observed some Cisco APs sending the following HE Operation IE in
associate response:

  ff 0a 24 f4 3f 00 01 fc ff 00 00 00

Its HE operation parameter is 0x003ff4, so the expected total length is
7 which does not match the actual length = 10. This causes association
failing with "HE AP is missing HE Capability/operation."

According to P802.11ax_D4 Table9-94, HE operation is extensible, and
according to 802.11-2016 10.27.8, STA should discard the part beyond
the maximum length and parse the truncated element.

Allow HE operation element to be longer than expected to handle this
case and future extensions.

Fixes: e4d005b80dee ("mac80211: refactor extended element parsing")
Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Yen-lin Lai <yenlinlai@chromium.org>
Link: https://lore.kernel.org/r/20210223051926.2653301-1-yenlinlai@chromium.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/mac80211/mlme.c
net/mac80211/util.c