]> git.ipfire.org Git - thirdparty/linux.git/commit
bonding: handle BOND_LINK_FAIL, BOND_LINK_BACK as valid link states
authorHangbin Liu <liuhangbin@gmail.com>
Wed, 4 Mar 2026 07:13:54 +0000 (15:13 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 7 Mar 2026 00:25:16 +0000 (16:25 -0800)
commit3348be7978f450ede0c308a4e8416ac716cf1015
tree3825c602fd9c6fe02a4c366d33d6f9163d77250d
parent45fc134bcfadde456639c1b1e206e6918d69a553
bonding: handle BOND_LINK_FAIL, BOND_LINK_BACK as valid link states

Before the fixed commit, we check slave->new_link during commit
state, which values are only BOND_LINK_{NOCHANGE, UP, DOWN}. After
the commit, we start using slave->link_new_state, which state also could
be BOND_LINK_{FAIL, BACK}.

For example, when we set updelay/downdelay, after a failover,
the slave->link_new_state could be set to BOND_LINK_{FAIL, BACK} in
bond_miimon_inspect(). And later in bond_miimon_commit(), it will treat
it as invalid and print an error, which would cause confusion for users.

[  106.440254] bond0: (slave veth2): link status down for interface, disabling it in 200 ms
[  106.440265] bond0: (slave veth2): invalid new link 1 on slave
[  106.648276] bond0: (slave veth2): link status definitely down, disabling slave
[  107.480271] bond0: (slave veth2): link status up, enabling it in 200 ms
[  107.480288] bond0: (slave veth2): invalid new link 3 on slave
[  107.688302] bond0: (slave veth2): link status definitely up, 10000 Mbps full duplex

Let's handle BOND_LINK_{FAIL, BACK} as valid link states.

Fixes: 1899bb325149 ("bonding: fix state transition issue in link monitoring")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Link: https://patch.msgid.link/20260304-b4-bond_updelay-v1-2-f72eb2e454d0@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/bonding/bond_main.c