]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: phy: honor eee_disabled_modes in phy_support_eee()
authorNicolai Buchwitz <nb@tipi-net.de>
Mon, 18 May 2026 08:23:09 +0000 (10:23 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 20 May 2026 01:45:26 +0000 (18:45 -0700)
commit3655063e083889ed4b79b7dda9cec65478dce09a
tree381f573411a2cb08b6d81eb1c30917c7aecd14a9
parent960e77ce14a83ef7f226e8e4b4d75765633ba48b
net: phy: honor eee_disabled_modes in phy_support_eee()

phy_support_eee() copies supported_eee into advertising_eee
unconditionally, overwriting any filtering applied during phy_probe()
based on DT eee-broken-* properties or driver-populated
eee_disabled_modes. MAC drivers that call phy_support_eee() after
probe (e.g. bcmgenet, fec, lan743x, lan78xx, r8169) then cause the PHY
to advertise EEE for modes the user marked as broken.

The symptom is that ethtool --show-eee on the local interface reports
"not supported" (supported & ~eee_disabled_modes is empty) while the
link partner sees EEE negotiated and active.

phy_probe() already filters advertising_eee via eee_disabled_modes
after calling of_set_phy_eee_broken(). Apply the same mask in
phy_support_eee() so the filtering survives the copy.

Fixes: 49168d1980e2 ("net: phy: Add phy_support_eee() indicating MAC support EEE")
Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260518-devel-phy-support-eee-fix-v2-1-05b52626fa68@tipi-net.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/phy_device.c