]> git.ipfire.org Git - thirdparty/linux.git/commit
netfilter: nft_fib_ipv6: bail out of sibling walk if rt got unlinked
authorJiayuan Chen <jiayuan.chen@linux.dev>
Tue, 26 May 2026 02:02:27 +0000 (10:02 +0800)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 1 Jun 2026 11:43:52 +0000 (13:43 +0200)
commit36d29ceec32c8206a12dc2810cf65fd394e45baa
tree01283216f0de683114bac01a8a5da2b71130bc72
parent193989cc6d80dd8e0460fb3992e69fa03bf0ff9b
netfilter: nft_fib_ipv6: bail out of sibling walk if rt got unlinked

This was reported by Sashiko [1].

The RCU walk over rt->fib6_siblings can spin forever if rt is unlinked
mid-iteration: rt->fib6_siblings.next still points into the old ring,
so the loop never meets &rt->fib6_siblings as its terminator.

fib6_purge_rt() always does WRITE_ONCE(rt->fib6_nsiblings, 0) before
list_del_rcu(), so readers can use rt->fib6_nsiblings == 0 as the
detach signal. The same pattern is used in fib6_info_uses_dev() and
rt6_nlmsg_size().

[1]: https://sashiko.dev/#/patchset/20260520023411.391233-1-jiayuan.chen%40linux.dev
Suggested-by: Florian Westphal <fw@strlen.de>
Fixes: 1c32b24c234b ("netfilter: nft_fib_ipv6: switch to fib6_lookup")
Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/ipv6/netfilter/nft_fib_ipv6.c