]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
nvme: fix race condition between connected uevent and STARTED_ONCE flag
authorMaurizio Lombardi <mlombard@redhat.com>
Fri, 8 May 2026 13:33:29 +0000 (15:33 +0200)
committerKeith Busch <kbusch@kernel.org>
Mon, 11 May 2026 17:07:20 +0000 (10:07 -0700)
commit37953cec775ed34e59cf9a7d7bb9b0610daa3f3e
tree0f106c1bf0c98d49f3c3888f2345cb5f0c6ffeb4
parent40df2172853ffc0f84cca3906f5c4d9a6131195d
nvme: fix race condition between connected uevent and STARTED_ONCE flag

When a controller connects, nvme_start_ctrl() emits the
"NVME_EVENT=connected" uevent and sets the NVME_CTRL_STARTED_ONCE flag.
Currently, the uevent is emitted before the flag is set. This creates a
race condition for userspace tools (like udev rules) that might rely on
the "connected" event to configure other attributes.

Swap the order of operations in nvme_start_ctrl() so that the
NVME_CTRL_STARTED_ONCE flag is set before the uevent is sent. This
guarantees that the admin_timeout can already be changed when userspace
is notified.

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Hannes Reinecke <hare@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/core.c