]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: dsa: fix spurious error message when unoffloaded port leaves bridge
authorAlvin Šipraga <alsi@bang-olufsen.dk>
Tue, 12 Oct 2021 11:27:31 +0000 (13:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Oct 2021 09:57:55 +0000 (11:57 +0200)
commit38eaccdcc81173c2f78e9936dce6cee29549988c
treef8b9062e1613f4cdb995154c97915ce5b533cbed
parent383239a33cf29ebee9ce0d4e0e5c900b77a16148
net: dsa: fix spurious error message when unoffloaded port leaves bridge

commit 43a4b4dbd48c9006ef64df3a12acf33bdfe11c61 upstream.

Flip the sign of a return value check, thereby suppressing the following
spurious error:

  port 2 failed to notify DSA_NOTIFIER_BRIDGE_LEAVE: -EOPNOTSUPP

... which is emitted when removing an unoffloaded DSA switch port from a
bridge.

Fixes: d371b7c92d19 ("net: dsa: Unset vlan_filtering when ports leave the bridge")
Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20211012112730.3429157-1-alvin@pqrs.dk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/dsa/switch.c