]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
USB: gadgetfs: fix copy_to_user while holding spinlock
authorAlan Stern <stern@rowland.harvard.edu>
Thu, 21 Sep 2017 20:12:01 +0000 (16:12 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Oct 2017 09:56:07 +0000 (11:56 +0200)
commit3a3bdf0a29bd13da53b3372c4587c2a8d0318170
tree8980765b682963637d15d07e4051f7a51a13f1f9
parent5b8bdd567735c761ebf24af6d5ebb29d5aadbc09
USB: gadgetfs: fix copy_to_user while holding spinlock

commit 6e76c01e71551cb221c1f3deacb9dcd9a7346784 upstream.

The gadgetfs driver as a long-outstanding FIXME, regarding a call of
copy_to_user() made while holding a spinlock.  This patch fixes the
issue by dropping the spinlock and using the dev->udc_usage mechanism
introduced by another recent patch to guard against status changes
while the lock isn't held.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Andrey Konovalov <andreyknvl@google.com>
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/legacy/inode.c