]> git.ipfire.org Git - thirdparty/linux.git/commit
tap: free page on error paths in tap_get_user_xdp()
authorWeiming Shi <bestswngs@gmail.com>
Thu, 21 May 2026 16:32:31 +0000 (09:32 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 22 May 2026 17:08:59 +0000 (10:08 -0700)
commit3bcf7aec6a9d16438f2cec29f5d7c8d5b8edf9b2
treebc88fb567c485e7c9877bea6e3e597cc0e64cb8e
parentf4feb1e20058e407cb00f45aff47f5b7e19a6bbf
tap: free page on error paths in tap_get_user_xdp()

tap_get_user_xdp() rejects a frame shorter than ETH_HLEN with -EINVAL,
and returns -ENOMEM when build_skb() fails. Both paths jump to the err
label without freeing the page that vhost_net_build_xdp() allocated for
the frame. tap_sendmsg() discards the per-buffer return value and always
returns 0, so vhost_tx_batch() takes the success path and never frees
the page; each rejected frame in a batch leaks one page-frag chunk.

Free the page on both error paths, before the skb is built. This is the
tap counterpart of the same leak in tun_xdp_one().

Fixes: 0efac27791ee ("tap: accept an array of XDP buffs through sendmsg()")
Fixes: ed7f2afdd0e0 ("tap: add missing verification for short frame")
Reported-by: Xiang Mei <xmei5@asu.edu>
Signed-off-by: Weiming Shi <bestswngs@gmail.com>
Reviewed-by: Dongli Zhang <dongli.zhang@oracle.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20260521163230.1478627-2-bestswngs@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/tap.c