]> git.ipfire.org Git - thirdparty/tor.git/commit
Treat an unexpected constant-sized VERSIONS cell as a PROTOCOL_WARN.
authorNick Mathewson <nickm@torproject.org>
Tue, 17 Sep 2019 13:09:36 +0000 (09:09 -0400)
committerNick Mathewson <nickm@torproject.org>
Tue, 17 Sep 2019 13:13:25 +0000 (09:13 -0400)
commit3c97ab3c24ba4a133377c7ec6ec89cc6903ffb2e
tree97a9fbc17d2ca0c4099db599992fa4a566eb0c15
parent5a1c3e44f758cda18bb0a0a8ef7c94a0122c85e4
Treat an unexpected constant-sized VERSIONS cell as a PROTOCOL_WARN.

We previously used tor_fragile_assert() to declare that this case
could not happen: VERSIONS cells are always supposed to be
variable-sized, right?

This is incorrect, though.  On a v1 link protocol connection, all
cells are fixed-sized.  There aren't supposed to be any VERSIONS
cells with this version of the protocol, but apparently, somebody
was messing up.  (The v1 link protocol is obsolete, so probably the
implementer responsible didn't mean to be using it.)

Fixes bug 31107.  Bugfix on 0.2.4.4-alpha, when we introduced a
tor_fragile_assert() for this case.
changes/bug31107 [new file with mode: 0644]
src/or/channeltls.c