]> git.ipfire.org Git - thirdparty/linux.git/commit
spi: sprd: fix error pointer deref after DMA setup failure
authorJohan Hovold <johan@kernel.org>
Tue, 12 May 2026 07:47:33 +0000 (09:47 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 18 May 2026 16:40:30 +0000 (17:40 +0100)
commit3d67fffb74267772d461c02c67f1eff893ad547d
treeafa0b89d6b801ec44501d4282081245a2e8c9084
parenta7e8f3efd50a165ba0189f6dc57f7e51a7d149db
spi: sprd: fix error pointer deref after DMA setup failure

The driver falls back to PIO mode if DMA setup fails during probe.

Make sure to check the dma.enabled flag before trying to release the DMA
channels also on late probe errors to avoid dereferencing an error
pointer (or attempting to release a channel a second time).

This issue was flagged by Sashiko when reviewing a devres allocation
conversion patch.

Fixes: 386119bc7be9 ("spi: sprd: spi: sprd: Add DMA mode support")
Link: https://sashiko.dev/#/patchset/20260505072909.618363-1-johan%40kernel.org?part=10
Cc: stable@vger.kernel.org # 5.1
Cc: Lanqing Liu <lanqing.liu@unisoc.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260512074733.915029-1-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-sprd.c