]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
drm/msm/dsi: fix 32-bit signed integer extension in pclk_rate calculation
authorJonathan Marek <jonathan@marek.ca>
Mon, 7 Oct 2024 05:01:49 +0000 (01:01 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Nov 2024 01:02:27 +0000 (02:02 +0100)
commit3db7f4e20e3ef3d4a28091e985827d8018c4934c
treebefe2bfd4241c62ebbcd0c2bd5f1bf4a2e707683
parent92c72b8f76cce2f27cab84263dce065b313a2ba4
drm/msm/dsi: fix 32-bit signed integer extension in pclk_rate calculation

[ Upstream commit 358b762400bd94db2a14a72dfcef74c7da6bd845 ]

When (mode->clock * 1000) is larger than (1<<31), int to unsigned long
conversion will sign extend the int to 64 bits and the pclk_rate value
will be incorrect.

Fix this by making the result of the multiplication unsigned.

Note that above (1<<32) would still be broken and require more changes, but
its unlikely anyone will need that anytime soon.

Fixes: c4d8cfe516dc ("drm/msm/dsi: add implementation for helper functions")
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/618434/
Link: https://lore.kernel.org/r/20241007050157.26855-2-jonathan@marek.ca
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/msm/dsi/dsi_host.c