]> git.ipfire.org Git - thirdparty/linux.git/commit
ethtool: cmis: fix u16-to-u8 truncation of msleep_pre_rpl
authorJakub Kicinski <kuba@kernel.org>
Fri, 22 May 2026 23:13:10 +0000 (16:13 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 26 May 2026 15:19:33 +0000 (08:19 -0700)
commit3e8c3d464c36bb342fe377b026577c7ec27fdbb4
tree802a556a9f53276f2943fd53aee9f5e401d8cdec
parent6c3f999a9d1338c6c89a9ff4549eafe72bc2e7b1
ethtool: cmis: fix u16-to-u8 truncation of msleep_pre_rpl

ethtool_cmis_cdb_compose_args() accepts msleep_pre_rpl as u16 but stores
it into the u8 field ethtool_cmis_cdb_cmd_args::msleep_pre_rpl, silently
truncating values >= 256. Seven of the nine call sites pass 1000 ms
(it's the third argument from the end).

Fixes: a39c84d79625 ("ethtool: cmis_cdb: Add a layer for supporting CDB commands")
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Danielle Ratson <danieller@nvidia.com>
Link: https://patch.msgid.link/20260522231312.1710836-8-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/cmis.h