]> git.ipfire.org Git - thirdparty/linux.git/commit
rxrpc, afs: Fix missing error pointer check after rxrpc_kernel_lookup_peer()
authorMiaoqian Lin <linmq006@gmail.com>
Thu, 5 Mar 2026 12:31:01 +0000 (12:31 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 7 Mar 2026 01:49:52 +0000 (17:49 -0800)
commit4245a79003adf30e67f8e9060915bd05cb31d142
treec6d980d86bab82f9f6d46459b5633eb0debff9e1
parent7a4d74676c31951c28b1df3dce4769d3acfb8e96
rxrpc, afs: Fix missing error pointer check after rxrpc_kernel_lookup_peer()

rxrpc_kernel_lookup_peer() can also return error pointers in addition to
NULL, so just checking for NULL is not sufficient.

Fix this by:

 (1) Changing rxrpc_kernel_lookup_peer() to return -ENOMEM rather than NULL
     on allocation failure.

 (2) Making the callers in afs use IS_ERR() and PTR_ERR() to pass on the
     error code returned.

Fixes: 72904d7b9bfb ("rxrpc, afs: Allow afs to pin rxrpc_peer objects")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Co-developed-by: David Howells <dhowells@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: Simon Horman <horms@kernel.org>
cc: linux-afs@lists.infradead.org
Link: https://patch.msgid.link/368272.1772713861@warthog.procyon.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
fs/afs/addr_list.c
net/rxrpc/af_rxrpc.c