]> git.ipfire.org Git - thirdparty/linux.git/commit
security/keys: fix missed RCU read section on lookup
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 28 May 2026 18:45:41 +0000 (11:45 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 28 May 2026 18:45:41 +0000 (11:45 -0700)
commit43a1e3744548e6fd85873e6fb43e293eb4010694
tree1718e70a9e68a7b3a3ba412f238df2365ffa6cb8
parenteb3f4b7426cfd2b79d65b7d37155480b32259a11
security/keys: fix missed RCU read section on lookup

Nicholas Carlini reports that the keyring code calls assoc_array_find()
in find_key_to_update() without holding the RCU read lock, while the
assoc_array_gc() code really is designed around removing the node from
the tree and then freeing it after an RCU grace-period.

The regular key handling doesn't see this because holding the keyring
semaphore hides any lifetime issues, but the persistent key handling
uses a different model.

Instead of extending the keyring locking, just do the simple RCU locking
that the assoc_array was designed for.

Reported-by: Nicholas Carlini <npc@anthropic.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Paul Moore <paul@paul-moore.com>
Cc: James Morris James Morris <jmorris@namei.org>
Cc: Serge E. Hallyn <serge@hallyn.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
security/keys/keyring.c