]> git.ipfire.org Git - thirdparty/bind9.git/commit
Move lock earlier in the call sequence
authorMark Andrews <marka@isc.org>
Wed, 28 Aug 2024 03:07:54 +0000 (13:07 +1000)
committerMark Andrews <marka@isc.org>
Thu, 29 Aug 2024 04:33:56 +0000 (04:33 +0000)
commit43f0b0e8ebafb968ee135beb877c7aa102959949
treee0fd0f5f02db36d2f69eaad57fd16882a5d20729
parent15b2f0125d40094dd9fb656b64bfe40f307eaf48
Move lock earlier in the call sequence

fctx->state should be read with the lock held.

    1559        /*
    1560         * Caller must be holding the fctx lock.
    1561         */

    CID 468796: (#1 of 1): Data race condition (MISSING_LOCK)
    1. missing_lock: Accessing fctx->state without holding lock fetchctx.lock.
       Elsewhere, fetchctx.state is written to with fetchctx.lock held 2 out of 2 times.
    1562        REQUIRE(fctx->state == fetchstate_done);
    1563
    1564        FCTXTRACE("sendevents");
    1565
    1566        LOCK(&fctx->lock);
    1567
lib/dns/resolver.c