]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
tee: qcomtee: add missing va_end in early return qcomtee_object_user_init()
authorRobertus Diawan Chris <robertusdchris@gmail.com>
Tue, 19 May 2026 02:05:28 +0000 (09:05 +0700)
committerJens Wiklander <jens.wiklander@linaro.org>
Wed, 20 May 2026 07:22:52 +0000 (09:22 +0200)
commit471c18323dfdfe7844e193b896a9267ae23a1026
tree8843c6ae399152dea7b89cf4219037f4677dc9a4
parent028ef9c96e96197026887c0f092424679298aae8
tee: qcomtee: add missing va_end in early return qcomtee_object_user_init()

qcomtee_object_user_init() is a variadic function and when the function
return because there's no dispatch callback in QCOMTEE_OBJECT_TYPE_CB
case, there's no va_end to cleanup "ap" object initialized by va_start
and that can cause undefined behavior. So make sure to use va_end before
returning the error code when there's no dispatch callback.

This is reported by Coverity Scan as "Missing varargs init or cleanup".

Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver")
Signed-off-by: Robertus Diawan Chris <robertusdchris@gmail.com>
Reviewed-by: Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
drivers/tee/qcomtee/core.c