]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: dvb: as102-fe: Fix as10x_register_addr packing
authorRicardo Ribalda <ribalda@chromium.org>
Wed, 10 Apr 2024 12:24:37 +0000 (12:24 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 Jul 2024 10:49:03 +0000 (12:49 +0200)
commit47abb68e17349da3dde5c16ce10b8a724fcf5c54
treefcea91b340e1b04085e6c7b49aee04d1289a1eee
parent0f37946c62c48a907625348cbc720a7a0c547d1e
media: dvb: as102-fe: Fix as10x_register_addr packing

[ Upstream commit 309422d280748c74f57f471559980268ac27732a ]

This structure is embedded in multiple other structures that are packed,
which conflicts with it being aligned.

drivers/media/usb/as102/as10x_cmd.h:379:30: warning: field reg_addr within 'struct as10x_dump_memory::(unnamed at drivers/media/usb/as102/as10x_cmd.h:373:2)' is less aligned than 'struct as10x_register_addr' and is usually due to 'struct as10x_dump_memory::(unnamed at drivers/media/usb/as102/as10x_cmd.h:373:2)' being packed, which can lead to unaligned accesses [-Wunaligned-access]

Mark it as being packed.

Marking the inner struct as 'packed' does not change the layout, since the
whole struct is already packed, it just silences the clang warning. See
also this llvm discussion:

https://github.com/llvm/llvm-project/issues/55520

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/dvb-frontends/as102_fe_types.h