]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: Fix regression caused by invalid ep0 maxpacket in virtual SuperSpeed device
authorAlan Stern <stern@rowland.harvard.edu>
Tue, 30 Apr 2024 14:33:48 +0000 (10:33 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 May 2024 10:02:28 +0000 (12:02 +0200)
commit480c3abbba36628dab063b9ca218bb28090e5b46
tree4a52ffa65d3b6bf9766f84e45ce2d517fd330fb8
parentd5f0c5ea3fc385c3c3c46bf0bc825b0b5e214f16
usb: Fix regression caused by invalid ep0 maxpacket in virtual SuperSpeed device

commit c78c3644b772e356ca452ae733a3c4de0fb11dc8 upstream.

A virtual SuperSpeed device in the FreeBSD BVCP package
(https://bhyve.npulse.net/) presents an invalid ep0 maxpacket size of 256.
It stopped working with Linux following a recent commit because now we
check these sizes more carefully than before.

Fix this regression by using the bMaxpacketSize0 value in the device
descriptor for SuperSpeed or faster devices, even if it is invalid.  This
is a very simple-minded change; we might want to check more carefully for
values that actually make some sense (for instance, no smaller than 64).

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-and-tested-by: Roger Whittaker <roger.whittaker@suse.com>
Closes: https://bugzilla.suse.com/show_bug.cgi?id=1220569
Link: https://lore.kernel.org/linux-usb/9efbd569-7059-4575-983f-0ea30df41871@suse.com/
Fixes: 59cf44575456 ("USB: core: Fix oversight in SuperSpeed initialization")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/4058ac05-237c-4db4-9ecc-5af42bdb4501@rowland.harvard.edu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hub.c