]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: seq: Drop UMP events when no UMP-conversion is set
authorTakashi Iwai <tiwai@suse.de>
Mon, 17 Feb 2025 17:00:30 +0000 (18:00 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Feb 2025 12:10:48 +0000 (04:10 -0800)
commit48e348ff3e180509f457e1251fb3471d430a25eb
tree52df52c0acc84516fa824df13d321173b7c2cdda
parentde4b679aa3b4da7ec34f639df068b914f20e3c3c
ALSA: seq: Drop UMP events when no UMP-conversion is set

[ Upstream commit e77aa4b2eaa7fb31b2a7a50214ecb946b2a8b0f6 ]

When a destination client is a user client in the legacy MIDI mode and
it sets the no-UMP-conversion flag, currently the all UMP events are
still passed as-is.  But this may confuse the user-space, because the
event packet size is different from the legacy mode.

Since we cannot handle UMP events in user clients unless it's running
in the UMP client mode, we should filter out those events instead of
accepting blindly.  This patch addresses it by slightly adjusting the
conditions for UMP event handling at the event delivery time.

Fixes: 329ffe11a014 ("ALSA: seq: Allow suppressing UMP conversions")
Link: https://lore.kernel.org/b77a2cd6-7b59-4eb0-a8db-22d507d3af5f@gmail.com
Link: https://patch.msgid.link/20250217170034.21930-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/core/seq/seq_clientmgr.c