]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
platform/x86: dell-wmi-sysman: Cleanup sysman_init() error-exit handling
authorHans de Goede <hdegoede@redhat.com>
Sun, 21 Mar 2021 11:58:59 +0000 (12:58 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Mar 2021 12:30:25 +0000 (14:30 +0200)
commit4940c55c47f0ae3c508b96181da2606137488dc2
tree556d5e4eacfadab1dd0b84be16c8a57536f5ad82
parent70b139ad0836d77c5a5c07a2e20fd212490656a2
platform/x86: dell-wmi-sysman: Cleanup sysman_init() error-exit handling

[ Upstream commit 9c90cd869747e3492a9306dcd8123c17502ff1fc ]

Cleanup sysman_init() error-exit handling:

1. There is no need for the fail_reset_bios and fail_authentication_kset
   eror-exit cases, these can be handled by release_attributes_data()

2. Rename all the labels from fail_what_failed, to err_what_to_cleanup
   this is the usual way to name these and avoids the need to rename
   them when extra steps are added.

Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Cc: Divya Bharathi <Divya_Bharathi@dell.com>
Cc: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210321115901.35072-6-hdegoede@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/x86/dell-wmi-sysman/sysman.c