]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/sched: act_ct: Fix skb double-free in tcf_ct_handle_fragments() error flow
authorAlaa Hleihel <alaa@mellanox.com>
Wed, 19 Aug 2020 15:24:10 +0000 (18:24 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Aug 2020 07:31:47 +0000 (09:31 +0200)
commit4c1fc05e5d6ab0af2c481721d6f2ca53d53c44ec
tree99bfddbe3f62770ac9584083e8947be102315e2d
parent351366ffef2c85e089039a76f45f196c5904acfa
net/sched: act_ct: Fix skb double-free in tcf_ct_handle_fragments() error flow

[ Upstream commit eda814b97dfb8d9f4808eb2f65af9bd3705c4cae ]

tcf_ct_handle_fragments() shouldn't free the skb when ip_defrag() call
fails. Otherwise, we will cause a double-free bug.
In such cases, just return the error to the caller.

Fixes: b57dc7c13ea9 ("net/sched: Introduce action ct")
Signed-off-by: Alaa Hleihel <alaa@mellanox.com>
Reviewed-by: Roi Dayan <roid@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sched/act_ct.c