]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix unsafe access to BufferDescriptors
authorRichard Guo <rguo@postgresql.org>
Wed, 19 Feb 2025 02:05:35 +0000 (11:05 +0900)
committerRichard Guo <rguo@postgresql.org>
Wed, 19 Feb 2025 02:10:46 +0000 (11:10 +0900)
commit4c6b5dd5f5cfaf42f2370f587df7238d5aba48b8
treeaf3dfb3cba4e87a8ac45425433191b46952d189d
parent8d0756250313c42b20f55ac62bece342c82a783d
Fix unsafe access to BufferDescriptors

When considering a local buffer, the GetBufferDescriptor() call in
BufferGetLSNAtomic() would be retrieving a shared buffer with a bad
buffer ID.  Since the code checks whether the buffer is shared before
using the retrieved BufferDesc, this issue did not lead to any
malfunction.  Nonetheless this seems like trouble waiting to happen,
so fix it by ensuring that GetBufferDescriptor() is only called when
we know the buffer is shared.

Author: Tender Wang <tndrwang@gmail.com>
Reviewed-by: Xuneng Zhou <xunengzhou@gmail.com>
Reviewed-by: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/CAHewXNku-o46-9cmUgyv6LkSZ25doDrWq32p=oz9kfD8ovVJMg@mail.gmail.com
Backpatch-through: 13
src/backend/storage/buffer/bufmgr.c