]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: gro: don't merge zcopy skbs
authorSabrina Dubroca <sd@queasysnail.net>
Wed, 20 May 2026 20:44:42 +0000 (22:44 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 21 May 2026 15:21:33 +0000 (08:21 -0700)
commit4db79a322db8c97f7b73b8a347395ef4d685eb40
treed50b56ff50c4989fbbf316afcd32ab7d11edec2b
parent3d4432d34c1992701289cbe12df9fd024f315998
net: gro: don't merge zcopy skbs

skb_gro_receive() can currently copy frags between the source and GRO
skb, without checking the zerocopy status, and in particular the
SKBFL_MANAGED_FRAG_REFS flag.

When SKBFL_MANAGED_FRAG_REFS is set, the skb doesn't hold a reference
on the pages in shinfo->frags. Appending those frags to another skb's
frags without fixing up the page refcount can lead to UAF.

When either the last skb in the GRO chain (the one we would append
frags to) or the source skb is zerocopy, don't merge the skbs.

Fixes: 753f1ca4e1e5 ("net: introduce managed frags infrastructure")
Reported-by: Huzaifa Sidhpurwala <huzaifas@redhat.com>
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/c3b7f906bbfcbdfd7b4fa9d6c18a438870df85be.1779307748.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/gro.c