]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix copy-paste error in test_ginpostinglist
authorJohn Naylor <john.naylor@postgresql.org>
Tue, 24 Mar 2026 09:40:33 +0000 (16:40 +0700)
committerJohn Naylor <john.naylor@postgresql.org>
Tue, 24 Mar 2026 10:17:47 +0000 (17:17 +0700)
commit4dc9346531e1833ebe482828aa75d0638895c9ec
tree4ebe81d2d4fd626bd5052102449ca1728cc4b52d
parente35e466f61b358f88f20fbebd3996c50589a6663
Fix copy-paste error in test_ginpostinglist

The check for a mismatch on the second decoded item pointer
was an exact copy of the first item pointer check, comparing
orig_itemptrs[0] with decoded_itemptrs[0] instead of orig_itemptrs[1]
with decoded_itemptrs[1].  The error message also reported (0, 1) as
the expected value instead of (blk, off).  As a result, any decoding
error in the second item pointer (where the varbyte delta encoding
is exercised) would go undetected.

This has been wrong since commit bde7493d1, so backpatch to all
supported versions.

Author: Jianghua Yang <yjhjstz@gmail.com>
Discussion: https://postgr.es/m/CAAZLFmSOD8R7tZjRLZsmpKtJLoqjgawAaM-Pne1j8B_Q2aQK8w@mail.gmail.com
Backpatch-through: 14
src/test/modules/test_ginpostinglist/test_ginpostinglist.c