]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/sched: act_skbedit: fix divide-by-zero in tcf_skbedit_hash()
authorRuitong Liu <cnitlrt@gmail.com>
Fri, 13 Feb 2026 17:59:48 +0000 (01:59 +0800)
committerSasha Levin <sashal@kernel.org>
Wed, 4 Mar 2026 12:21:33 +0000 (07:21 -0500)
commit4ece5eb4836f8ff03b9004dc2430a7169f282851
tree150a821778482822edd6f1a84c144fd5f41fefdb
parent1b1d3c5d58a80a19d017a409aa2308162bab5bbf
net/sched: act_skbedit: fix divide-by-zero in tcf_skbedit_hash()

[ Upstream commit be054cc66f739a9ba615dba9012a07fab8e7dd6f ]

Commit 38a6f0865796 ("net: sched: support hash selecting tx queue")
added SKBEDIT_F_TXQ_SKBHASH support. The inclusive range size is
computed as:

mapping_mod = queue_mapping_max - queue_mapping + 1;

The range size can be 65536 when the requested range covers all possible
u16 queue IDs (e.g. queue_mapping=0 and queue_mapping_max=U16_MAX).
That value cannot be represented in a u16 and previously wrapped to 0,
so tcf_skbedit_hash() could trigger a divide-by-zero:

queue_mapping += skb_get_hash(skb) % params->mapping_mod;

Compute mapping_mod in a wider type and reject ranges larger than U16_MAX
to prevent params->mapping_mod from becoming 0 and avoid the crash.

Fixes: 38a6f0865796 ("net: sched: support hash selecting tx queue")
Cc: stable@vger.kernel.org # 6.12+
Signed-off-by: Ruitong Liu <cnitlrt@gmail.com>
Link: https://patch.msgid.link/20260213175948.1505257-1-cnitlrt@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sched/act_skbedit.c