]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: sun4i-spdif: Make reset control non-optional and check for all errors
authorChen-Yu Tsai <wens@csie.org>
Mon, 23 Mar 2026 17:24:48 +0000 (01:24 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 24 Mar 2026 00:11:20 +0000 (00:11 +0000)
commit51b0909d0bc479b37db5f26674a7c41676aa8f80
tree7a6131f0a1f215b5e5456a23c20d4eb5fa871d33
parent1001b4735137894a6bd7b5bf73375cfa27b6125e
ASoC: sun4i-spdif: Make reset control non-optional and check for all errors

The logic around the reset control is weird. The driver already has
quirks describing which compatible strings require a reset control, but
the reset control is acquired using the "optional" API. Then any errors
other than deferred probe are ignored.

Instead, switch to the non-optional variant. Also use the deassered
variant to simplify the code. This also fixes a missing reset assert
upon removal.

Last, clean up the error message printing with dev_err_probe().

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://patch.msgid.link/20260323172450.1259111-1-wens@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sunxi/sun4i-spdif.c