]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
can: can_dropped_invalid_skb(): ensure an initialized headroom in outgoing CAN sk_buffs
authorOliver Hartkopp <socketcan@hartkopp.net>
Sat, 7 Dec 2019 18:34:18 +0000 (19:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jan 2020 19:05:42 +0000 (20:05 +0100)
commit54a5ba5136c188c9d349236cc0a0abc5dc0a899d
tree7c5a66540a0cfdbce6bd9c3b4a19d2aa25caf50b
parente08e3dda248f115c77fc59016d26fdc1fd19cf58
can: can_dropped_invalid_skb(): ensure an initialized headroom in outgoing CAN sk_buffs

commit e7153bf70c3496bac00e7e4f395bb8d8394ac0ea upstream.

KMSAN sysbot detected a read access to an untinitialized value in the
headroom of an outgoing CAN related sk_buff. When using CAN sockets this
area is filled appropriately - but when using a packet socket this
initialization is missing.

The problematic read access occurs in the CAN receive path which can
only be triggered when the sk_buff is sent through a (virtual) CAN
interface. So we check in the sending path whether we need to perform
the missing initializations.

Fixes: d3b58c47d330d ("can: replace timestamp as unique skb attribute")
Reported-by: syzbot+b02ff0707a97e4e79ebb@syzkaller.appspotmail.com
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: linux-stable <stable@vger.kernel.org> # >= v4.1
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/can/dev.h