]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
clocksource/drivers/cadence-ttc: Fix memory leak in ttc_timer_probe
authorFeng Mingxi <m202271825@hust.edu.cn>
Tue, 25 Apr 2023 06:56:11 +0000 (06:56 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jul 2023 06:37:05 +0000 (08:37 +0200)
commit54cc10a0f4b01b522e9519014200f1b33bf7e4aa
treee2acceaa9394355339668459c615ef2092698aad
parent38ca169d66c379abf35c598c53f3ad75e4a8bbd6
clocksource/drivers/cadence-ttc: Fix memory leak in ttc_timer_probe

[ Upstream commit 8b5bf64c89c7100c921bd807ba39b2eb003061ab ]

Smatch reports:
drivers/clocksource/timer-cadence-ttc.c:529 ttc_timer_probe()
warn: 'timer_baseaddr' from of_iomap() not released on lines: 498,508,516.

timer_baseaddr may have the problem of not being released after use,
I replaced it with the devm_of_iomap() function and added the clk_put()
function to cleanup the "clk_ce" and "clk_cs".

Fixes: e932900a3279 ("arm: zynq: Use standard timer binding")
Fixes: 70504f311d4b ("clocksource/drivers/cadence_ttc: Convert init function to return error")
Signed-off-by: Feng Mingxi <m202271825@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Acked-by: Michal Simek <michal.simek@amd.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230425065611.702917-1-m202271825@hust.edu.cn
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clocksource/timer-cadence-ttc.c