]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
r8152: fix the firmware doesn't work
authorHayes Wang <hayeswang@realtek.com>
Tue, 3 Sep 2024 06:33:33 +0000 (14:33 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Sep 2024 09:11:34 +0000 (11:11 +0200)
commit565eb51b3d801ad400b6a39ebfbec9c0e675bc84
tree493aead143c4cd5ad02878c7b6b1440fd50c6357
parent1df42be305fe478ded1ee0c1d775f4ece713483b
r8152: fix the firmware doesn't work

[ Upstream commit 8487b4af59d4d7feda4b119dc2d92c67ca25c27e ]

generic_ocp_write() asks the parameter "size" must be 4 bytes align.
Therefore, write the bp would fail, if the mac->bp_num is odd. Align the
size to 4 for fixing it. The way may write an extra bp, but the
rtl8152_is_fw_mac_ok() makes sure the value must be 0 for the bp whose
index is more than mac->bp_num. That is, there is no influence for the
firmware.

Besides, I check the return value of generic_ocp_write() to make sure
everything is correct.

Fixes: e5c266a61186 ("r8152: set bp in bulk")
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Link: https://patch.msgid.link/20240903063333.4502-1-hayeswang@realtek.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/usb/r8152.c