]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
gpiolib: of: fix a memory leak in of_gpio_flags_quirks()
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Sat, 6 Jul 2019 13:34:22 +0000 (19:04 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 28 Jul 2019 06:27:21 +0000 (08:27 +0200)
commit594a0e0d11b86d84a67b683a4cbe0bed17fa00b0
treea7b084689936041a611c5f3f8fcbc2fc52d61d10
parent52da09f58290b7165a54798b6008bc1a803ed3c4
gpiolib: of: fix a memory leak in of_gpio_flags_quirks()

commit 89fea04c85e85f21ef4937611055abce82330d48 upstream.

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a break from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the break.
Issue found with Coccinelle.

Cc: <stable@vger.kernel.org>
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
[Bartosz: tweaked the commit message]
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpio/gpiolib-of.c